koji

#1068 hub: [getRPMFile] add strict behavior
Merged by tkopecek. Opened by julian8628.
julian8628/koji issue/1053  into  master

Download 1068.patch

fixes: #1053
fixes: #1054

change this comparison for python3, should I also change the result as well?

@julian would fixEncoding be needed with #1070?

@julian would fixEncoding be needed with #1070?

no, it look good and for python3, byte values in result turn to string.

1 new commit added

  • using decoded result in PR#1070

@tkopecek I updated this PR based on PR #1070

debug?

2 new commits added

  • using decoded result in PR#1070
  • hub: [getRPMFile] add strict behavior

debug?

oh, removed this line. Thanks

 
tests/test_hub/test_getRPMFile.py:6:1: F401 'six.b' imported but unused

2 new commits added

  • using decoded result in PR#1070
  • hub: [getRPMFile] add strict behavior

tests/test_hub/test_getRPMFile.py:6:1: F401 'six.b' imported but unused

updated

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

I don't think the import changes are relevant here. Can you drop them and rebase? The master branch has a number of import changes on it already.

While it makes sense to apply cleanup as we work, it is also important to keep PRs on topic.

rebased onto 9995da32c4b7510e1e4eccc7eed4bbaf00d4fd1d

sure, updated

imports were re-organized automatically by my ide :smoking:

pretty please pagure-ci rebuild

@julian8628 Can you rebase it, please?

rebased onto 473bc1460bf39e5ce8e5023b13484156bda1dbff

updated

Commit 51a68320 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.