#1070 consolidate access to rpm headers
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue1069  into  master

Download 1070.patch

Fixes: https://pagure.io/koji/issue/1069

:thumbsup:

A few updates
https://github.com/mikem23/koji-playground/commits/pagure/pr/1070

:thumbsup:

Changes are ok. Nevertheless, I'm wondering why == 1 is needed? For non-source rpms None is returned.

Changes are ok. Nevertheless, I'm wondering why == 1 is needed? For non-source rpms None is returned.

We could go for a simpler boolean test, but the previous code reversed the logic.

Ooops! I see that now.

Looks like a lot of this was already in master from the py3 work. Rebasing dropped it down to just a few changes. Also, I noticed that kojivmd had an RPMTAG_ ref.

https://github.com/mikem23/koji-playground/commits/pagure/pr/1070

Commit 273c18c9 fixes this pull-request

Pull-Request has been merged by mikem

Metadata