koji

#1086 hub: unittest for get_external_repos
Merged by mikem. Opened by julian8628.
julian8628/koji issue/1077  into  master

Download 1086.patch

relates: #1077
Since this call is a query API, and if no external_repo items found, empty list should be returned.
There's no significant reason to raise Error or add strict behavior in this case.

See my comments on #1077. I'm not sure this is an sensible call to add a strict option to.

Also, this change will also raise an error when the call is used without parameters (query all ext repos) and there are no ext repos defined in the system. This is a different case than #1077 and #1078 complain about.

See my comments on #1077. I'm not sure this is an sensible call to add a strict option to.
Also, this change will also raise an error when the call is used without parameters (query all ext repos) and there are no ext repos defined in the system. This is a different case than #1077 and #1078 complain about.

I agree with you that this call shouldn't have a strict behavior like that. I will change this PR having only unittests

rebased onto 511dddbd79e1f43260a2f84909cc3e13d7847771

rebased onto a3ff86c1fa4e9db941e6fbdb3a104e355360a11d

updated

Commit d6b78328 fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.