PR#1172: make timeout of authentication configurable -

fixes: #1171

default value is not extracted out here.

An explicit auth_timeout = 0 ought to mean no timeout for auth, but this expression will give 60 in that case:

self.opts['timeout'] = self.opts.get('auth_timeout') or 60

Instead, I think we should apply the default using the option to get, e.g.

self.opts['timeout'] = self.opts.get('auth_timeout', 60)

We also need to update the comment above that mentions "60 seconds". Perhaps just change it to say "temporary timeout value during login"

Actually, we probably want to change the default value in get_config as well.

It's probably worth keeping the default in the session code also, for scripts that don't use read_config().

1 new commit added

Nov 27, 2018

@mikem
updated it

Commit a05478e2 fixes this pull-request

Pull-Request has been merged by mikem

Nov 27, 2018

Assignee

None

Tags

No Tags