koji

#1173 hub: [groupListRemove] raise Error when no group for tag
Merged by tkopecek. Opened by julian8628.
julian8628/koji issue/1090  into  master

Download 1173.patch

fixes: #1090

using force=True to avoid throwing error when no item found in DB

docstrings! :heart:

It's customary to have these at the very end, mind moving "Permission required: admin" up into its own paragraph above the Sphinx lines?

rebased onto c77573e061143e1c347ca25b6d212b2a8abcbe93

rebased onto e4272fb9943b886d4364da38a85717ea8a702fcc

@ktdreyer
updated

This seems to be a substitution misfire

It's not completely clear what force should mean here. I think this is a relic of some previous behavior in the function.

In any case, I'm not sure that recycling this param to mean "not strict" is the right thing here.

rebased onto bad108f83ce70512846ce808522aabc0873bf359

This seems to be a substitution misfire

my bad :dizzy_face:
updated

It's not completely clear what force should mean here. I think this is a relic of some previous behavior in the function.
In any case, I'm not sure that recycling this param to mean "not strict" is the right thing here.

IMO,
- strict: for get* APIs, to raise Error when input/output not found
- force: for create/update/delete APIs, to avoid raising Error and do the action when some conflict happens

1 new commit added

  • fix unavailable id column

Commit fa7c2076 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.