koji

#1174 cli: [download-task] call getTaskInfo with strict=True
Closed by julian8628. Opened by julian8628.
julian8628/koji issue/1080  into  master

Download 1174.patch

fixes: #1080

it's a follow-up change after strict behavior is enabled in getTaskinfo()

With current master (d8ccc94cba32cd7520f7339a69ff06c92ac781d7):

$ koji download-task 1000000000
No such task: #1000000000

With this change:

$ koji download-task 1000000000
2018-11-28 14:40:52,083 [ERROR] koji: GenericError: query returned no rows

So, #1080 was already fixed and this results in a less useful error message.

I guess the followup should be to fix the error message returned by getTaskInfo. Even if we do that though, this change would still replace an error message plus exit with an raised exception. The behavior of the latter is somewhat less friendly --- traceback shown in debug output and exception name shown in all cases.
Edited by mikem

make sense.
I was going to make getTaskInfo to throw an GenericError with more friendly message, but it looks not that worthy.
cc @jcupova, how do you think about?
The idea of raising GenericError comes from https://pagure.io/koji/pull-request/1098#comment-69654

@julian8628 - should this be closed as @1080 is already closed? Or is this addressing something more?

Yes. Closed this as an invalid one

Pull-Request has been closed by julian8628
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.