koji

#1220 Fix non-ascii strings in xmlrpc
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue1219  into  master

Download 1220.patch

requests library refuse to upload non-latin-1 strings, convert data to
utf-8 before passing to library.

Fixes: https://pagure.io/koji/issue/1219

I'm not overly happy with this solution. Nevrtheless, encoding it inside dumps or in the ExtendedMarshaller triggers further problems with passing binary strings in py3 and storing them in hub. I'm open to other proposals.

rebased onto 70277ff302f561ebf8e3febf300f3f3ad0d13594

is this a separate change?

rebased onto 250088ed7ef304bb65845f70ee059bad48bff64c

I've put typo fix separately: PR #1243

Definitely not the ideal fix, but it seems to work.

Putting the structural concerns aside, what sticks out to me is that we don't really need to do any of this encoding on py2. Or am I missing something about the issue?

https://github.com/mikem23/koji-playground/commits/pagure/pr/1220

yep, it is sufficient

Fixes: #1202

Commit 5ca71d7a fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.