#1227 Added volume id as argument to livemedia and livecd tasks
Merged by mikem. Opened by breilly.
breilly/koji volumeid-833  into  master

Download 1227.patch
no initial comment

Fixes https://pagure.io/koji/issue/833

:thumbsup:

Maybe log some warning if supplied volid was truncated? Also I would check it on CLI side, so we can fail the command with wrong (long) volid.

To be clear, do you mean log a warning if the volid passed is longer than 32 characters, and if a volid longer than 32 characters was passed via the CLI, fail at that point?

1 new commit added

  • Added warnings and failures for too long volid

The refs to logger need to be self.logger here

https://github.com/mikem23/koji-playground/commits/pagure/pr/1227

Also, I wonder if the task should just fail outright if a passed-in volid is too long. We're failing on the cli side.

Yeah, I think it's better to error early if the passed in volid is too long. I've made that change here and I'll merge that

https://github.com/mikem23/koji-playground/commits/pagure/pr/1227

Commit 4f450593 fixes this pull-request

Pull-Request has been merged by mikem

Metadata