PR#1235: fix weak deps handling in rpminfo web page -

koji

#1235 fix weak deps handling in rpminfo web page

Merged Feb 18, 2019 by mikem. Opened Feb 7, 2019 by tkopecek.

tkopecek/koji issue1234 into master

tkopecek commented Feb 7, 2019

PR #965 (commit ef998c6) changed way, how weak reference support is
detected in rpm. As a result, web page rpminfo is failing due to missing
variable.

Fixes: https://pagure.io/koji/issue/1234

ngompa commented Feb 7, 2019

:thumbsup:

mikem commented Feb 18, 2019

The web ui might not be running on the same platform as the hub, which is where the querying of the rpm actually happens. So this check is not telling us whether the hub can actually report these deps.

Since we have the dependency type constants in koji directly (e.g. koji.DEP_SUGGEST), I don't think we actually need rpm on the web system to understand these deps. We do need to know if the hub does not support them so we can avoid showing them as empty when we do not know that.

mikem commented Feb 18, 2019

That said, this is probably good enough for now. I don't see any way to figure out whether the hub supports these with the current api.

mikem commented Feb 18, 2019

Commit a34d50e4 fixes this pull-request

Pull-Request has been merged by mikem

Feb 18, 2019

mikem commented Feb 18, 2019

Filed #1261 as a follow up