#1238 plugin: create target_multi_tag plugin
Opened by jcpunk. Modified
jcpunk/koji target-multi-dest  into  master

Download 1238.patch

This hub-plugin will perform additional tagging on completed builds as part of the build task.

For reasons I've been unable to determine, the subtask is calling 'host.tagBuild' rather than 'tagBuild'.

Any ideas?

@jcpunk host version tags build as a user, who spawned the original build task, non-host will tag it as a builder machine. It depends on your usecase, which one makes more sense here. Maybe it could be configurable?

Also I'm not sure if this plugin should be in base koji, or as part of koji-tools. But as koji-tools plugin packaging is not ready, I would probably stay here.

For my usage, I'd expect it to run as the user who spawned the task. That should help keep permissions/tasks/audit sane.

I noticed 'host.tagBuild' doesn't seem to check if package is in tag before tagging it in.

https://pagure.io/koji/blob/master/f/hub/kojihub.py#_9463
vs
https://pagure.io/koji/blob/master/f/hub/kojihub.py#_12431

@tkopecek I'm happy to help with packaging koji-tools . Do you mean that it's simply not in Fedora, or something else?

@ktdreyer It is packages, but I wanted to create new subpackage with additional CLI/hub/builder plugins. There is already one candidate in https://pagure.io/koji-tools/pull-request/5 . Of course, it is now little complicated with all those py2/3 madness.

Issue: https://pagure.io/koji/issue/1570

rebased onto bf732505c9c7be6e7c9d009616351e1e0c7c87ed

Metadata