PR#1246: split admin_emails option for kojid -

koji

#1246 split admin_emails option for kojid

Merged Dec 19, 2019 by tkopecek. Opened Feb 13, 2019 by tkopecek.

tkopecek/koji issue1240 into master

Download 1246.patch

tkopecek commented Feb 13, 2019

If there are multiple e-mailes separated by comma of space, they should
be split for correct usage of smtplib.sendmail.

Fixes: https://pagure.io/koji/issue/1240

ngompa commented Feb 13, 2019

:thumbsup:

ngompa commented Feb 13, 2019

While this looks good, wouldn't a nargs type option work here? That way it can accept multiple items and turn it into a tuple?

rebased onto 601686c9d2f657ae0d49fb0e74fc705f28498a00

Apr 16, 2019

tkopecek commented Sep 30, 2019

ping @breilly @julian8628

julian8628 commented Nov 13, 2019

:thumbsup:

1 new commit added

fix splitting addresses

Nov 14, 2019

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Nov 14, 2019

mikem commented Nov 14, 2019

With this change, options.admin_emails can be either a string, a list, or None. Whereas before it was either a string or None.

This changes the api (renames an arg for add_mail_logger), and changes the usage for the kojid and kojivmd.

I think simply the list conversion added to add_mail_logger is sufficient to address #1240. I would also not rename the arg. While I don't expect that outside code is necessarily calling this with named args, I'm also hesitant to make api changes for a case like this when the misnomer could simply be explained in the docstring.

tkopecek commented Nov 18, 2019

Makes sense, updated

rebased onto 42572874d9d2e5f4e1de0ce21d4c5e223307716a

Nov 18, 2019

breilly commented Nov 22, 2019

:thumbsup:

mikem commented Dec 18, 2019

:thumbsup:

tkopecek commented Dec 19, 2019

Commit 1ddb03dc fixes this pull-request

Pull-Request has been merged by tkopecek

Dec 19, 2019