:thumbsup:

@mikem - It is marked as testing-done, ready for merge?

Ah, I had envisioned including the search form in the results page, but this is helpful too. Perhaps not obvious where to look if you used the full search form instead of the top bar.

This doesn't propagate the search type. If you search for tags matching k*, the resulting page is prefilled with a search for packages instead.

If I search for <, the box on the results page is prefilled with <. Suspicious.

I've addded support to search page directly and fixed search type.
Html escaping is problem, as all templates go through XHTMLFilter, so '<' is converted to '<' and it is then escaped by cgi.escape back to '&lt', which is displayed as '<' in browser. (see html source of final page). So raw query is already lost inside the template - I don't think it is worthy to rewrite XHTMLFilter usage just because of this usecase.

I've added support to search page directly and fixed search type.

I see the changes in search.chtml, but they don't do anything because a different template is used for search results.

Combining the two templates seems to make things work.

https://github.com/mikem23/koji-playground/commits/pagure/pr/1258

Tests well with devtools/fakeweb

example screenshot of above attached to #1130

I think I've convinced myself that the XHTMLFilter business is safe

Yes, this works better. There were more combinations which I've not investigated enough (find exactly one result, find more results, wrong query).

Does it make sense now to put whole search form search.html in one row now? It is less scrolling if there are more results.

Does it make sense now to put whole search form search.html in one row now?

Sure, seems to look ok that way. I've updated my branch

https://github.com/mikem23/koji-playground/commits/pagure/pr/1258

Cases that appear to work fine for me (via fakeweb at least):

• single result (jumps straight to that page)
• navigating through result pages (works, and still preserves form)
• no match (shows "No search results")
• invalid search (shows error message and preserves form)

:thumbsup:

Commit 2cf37f6c fixes this pull-request