1 new commit added
add PYTHONPATH for web tests
Why is this commented out?
To be honest - I was not able to figure out, why it is there. json should store calls to hub and return values. Values in json don't need to be converted at all (no change of data in py2). If it stays there, even keys in dict are bytes in py3 and call['method'] should be call[six.b('method')], etc.
call['method']
call[six.b('method')]
It is originally written by @mikem - Mike, any concerns with this?
I don't recall precisely. This was from #628, and even right after that merge, the line appears to be unnecessary,
My best guess is that it is an artifact of an earlier version of the test. I think I played around with different ways to store the cached calls before setting on json. Unfortunately, I dropped my original branch some time after the merge, so I cannot see the reflog for it anymore.
Commit 4f45ccee fixes this pull-request
Pull-Request has been merged by mikem