koji

#1271 decode Popen.communicate result under py3
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue1270  into  master

Download 1271.patch

Fixes: https://pagure.io/koji/issue/1270

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

:thumbsup:

unit tests break on py3. looks like we need to adjust the mocking

======================================================================
ERROR: test_get_source_git (tests.test_scm.TestSCMCheckouts)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/home/mike/Devel/koji/koji/tests/test_scm.py", line 396, in test_get_source_git
    source = scm.get_source()
  File "/home/mike/Devel/koji/koji/koji/daemon.py", line 538, in get_source
    fragment = fragment.decode()
AttributeError: 'str' object has no attribute 'decode'
----------------------------------------------------------------------

1 new commit added

  • fix unittest for py3

updated

Commit d92461ff fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None

testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.