PR#1290: downloadTaskOutput fix for py3 -

koji

#1290 downloadTaskOutput fix for py3

Merged Feb 28, 2019 by mikem. Opened Feb 26, 2019 by tkopecek.

tkopecek/koji issue1289 into master

Download 1290.patch

tkopecek commented Feb 26, 2019

Fixes: https://pagure.io/koji/issue/1289

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Feb 26, 2019

ngompa commented Feb 26, 2019

:thumbsup:

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Feb 27, 2019

mikem commented Feb 27, 2019

This changes the API

The downloadTaskOutput handler returns a string that contains base64 encoded data. It does not use the base64 tag in xmlrpc encoding. With this change, it returns binary data encoded in a base64 xmlrpc tag (so double base64 encoded), but only on a py3 hub.

mikem commented Feb 27, 2019

updates here:
https://github.com/mikem23/koji-playground/commits/pagure/pr/1290

Edited Feb 27, 2019 by mikem

mikem commented Feb 28, 2019

@tkopecek how does that look to you?

tkopecek commented Feb 28, 2019

yes, better

mikem commented Feb 28, 2019

Commit 3a1e9a93 fixes this pull-request

Pull-Request has been merged by mikem

Feb 28, 2019