#1358 rollback errors in multiCall
Merged by mikem. Opened by mikem.
mikem/koji multicall-rollback  into  master

Download 1358.patch

Fixes: https://pagure.io/koji/issue/1357

@tkopecek

h/t @ahills

Also there is no clear understanding of how commits should work for multicall. Do we expect, that each call has its own transaction (as it could be naive expectation), or that all calls are committed at once (as it is in reality)? It probably does matter only for pre/postCommit callbacks and possibly for some intended "atomic" calls. It is probably just matter of docs to be more clear on that, then of changing the code.

each call has its own transaction (as it could be naive expectation)

I'm not sure that's the expectation. I've spoken to a number of people that expected multicall to be single transaction, as it is.

Agreed it should be documented

1 new commit added

  • document multicall

See also: #957

:thumbsup:

pretty please pagure-ci rebuild

rebased onto a8fb6c952d77cc65a23af1e824c411ad2ef04a34

Commit 7fb56ee3 fixes this pull-request

Pull-Request has been merged by mikem

Metadata