koji

#138 don't bind-mount /dev for LiveMediaTask (RHBZ #1315541)
Merged by mikem. Opened by adamwill.
adamwill/koji live-no-dev  into  master

Download 138.patch

This is an alternative to https://pagure.io/koji/pull-request/137
which keeps the /dev bind mount for ApplianceTask and LiveCDTask,
only dropping it for LiveMediaTask. It seems from the test we
ran that appliance-creator may still need it, at least for the
present - some of the createAppliance tasks seemed to hang their
builders.

Note I don't have a test koji deployment so I have not tested this, please check it for obvious errors :)

this will break things horribly. if bind_opts exists koji turns off mocks internal dev setup. you will end up without /dev completely

uh, what? I know it does. But that's why I made sure the other two cases don't pass it.

for the record, we did the F25 Alpha 1 compose with this patch and it seems to have worked fine, all lives and appliances worked.

Commit d7e85708 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

well, except it incorrectly attributes the change to you, not me. but never mind.

@adamwill I authored the merge commit, you authored the commit that was merged. Just gotta look at the history.

https://pagure.io/koji/c/c72090b1ffba737a5c32ec42644d0893ca61bc5a

sorry, my bad, I only looked at the link - didn't notice it was a merge commit.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.