koji

#1465 unittest fix: tests/test_cli/test_list_tagged.py
Merged by tkopecek. Opened by julian8628.
julian8628/koji fix-test_list_tagged  into  master

Download 1465.patch
no initial comment

Can you explain what you are fixing?

I am concerned that a "broken" test has been succeeding for so long. Do we have similar mistakes elsewhere? Is the assert_console_message utility function too forgiving?

ping @julian8628

@mikem @tkopecek
I'm fixing that assert_console_message was directly using sys.stdout for unittest without mocking. It will fail when some other factor like nosetests-2 tests/test_cli/test_list_tagged.py -s

But I didn't directly change assert_console_message, as test_list_tagged.py is the only place without mocking sys.stdout...

:thumbsup:

Issue #1902

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

Commit 8502d4d4 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

no_qe

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.