koji

#1488 Display params also for malformed tasks in webui
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue1484  into  master

Download 1488.patch

Previously web ui failed in displaying tasks with unexpected parameters,
display them now in raw variant with warning message.

Fixes: https://pagure.io/koji/issue/1484

pretty please pagure-ci rebuild

:thumbsup:

:thumbsup:

Simple verify test with local instance:

lkoji call --python makeTask '"build"' '["bring us a shrubbery"]'

With the old code, the taskinfo page errors with IndexError: list index out of range

With the new code, however, we see partial template output with the error message stuck in an odd place. In this case, the message is the text for a link (with a nonsense href value).

It seems that #try...#except in a Cheetah template can yield unpredictable output

devtools/fakeweb is sufficient for me to replicate the issue.

rebased onto 1f65f7174ef477a45dd06d31af306a0f2caabc83

I've put whole params rendering to separate template. It seems to be the easiest way to do it with cheetah.
Edited by tkopecek

rebased onto a74d0f7b3cc75ad36bba3f80107e2ebc02e49a1e

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

rebased onto f4349333700403164f068c30e534f68346d37647

Commit 8f454e23 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.