@tkopecek Why not install this into some place like /usr/libexec/koji-hub and have a small wrapper to call it in cron or systemd timers or whatever? That way people can easily call it, or it can be done from Ansible, or whatever easily.

Yep, maybe libexec is better location. What about default installation? I still hesitate between implicit installation (as in current PR) and just documentation and explicit based on (installation) docs.

for a cron job, I'd probably suggest documentation. For systemd timers, we should install, since they don't get enabled by default.

updated

We assume systemd in other places in our documentation, so I think we could remove the references to cron and just give the exact systemd steps here.

Code-wise, LGTM :thumbsup:

This part isn't strictly necessary--if enabled, it will run every time multi-user.target is reached. Hit the "comment" icon on the source. "This part" refers to the [Install] section of the service unit (not the timer unit).

Why is this here? We don't need a Unit= statement here, and it has no value set anyway...

:thumbsup:

Added build_reservation cleanup.

ping @julian8628 @breilly

:thumbsup:

ping @breilly

:thumbsup:

Commit 6c97ff43 fixes this pull-request