PR#1589: query builds per chunks in prune-signed-builds -

koji

#1589 query builds per chunks in prune-signed-builds

Merged Sep 26, 2019 by tkopecek. Opened Jul 30, 2019 by tkopecek.

tkopecek/koji issue1587 into master

Download 1589.patch

tkopecek commented Jul 30, 2019

For bigger installations query all builds can run out of memory on hub
side. Query these in 50k chunks.

Fixes: https://pagure.io/koji/issue/1587

ngompa commented Aug 3, 2019

:thumbsup:

mikem commented Aug 23, 2019

There's a stray debugging print call in there

mikem commented Aug 23, 2019

At some point we probably need to consolidate the chunked builds code, since we have different versions of it different places (including in koji-tools), but I don't think we have to make that part of this PR.

Also, it would be nice to have a guaranteed stable way of doing these chunked queries. At the moment, it's technically possible to miss a build or see a duplicate if the query results change in the middle. Again, probably something to tackle separately.

mikem commented Aug 23, 2019

I've filed #1628 to track my comments above.

mikem commented Aug 23, 2019

Otherwise looks fine and seems to be working here. Just need to drop the stray print()

rebased onto 462ad65522334cf2c8d68d2383dcdd5ba9defc81

Aug 27, 2019

tkopecek commented Aug 27, 2019

updated

tkopecek commented Sep 26, 2019

Commit bf624f56 fixes this pull-request

Pull-Request has been merged by tkopecek

Sep 26, 2019