#1615 use only createrepo_c, drop createrepo
Closed by tkopecek. Opened by tkopecek.
tkopecek/koji issue1336  into  master

Download 1615.patch

createrepo_c/mergerepo_c already supports everything we needs in koji.
There is no reason to support internal implementation of mergerepo and
all distributions in sight already have createrepo_c.

Commit is dropping all createrepo/mergerepo uses and replace them with
their _c variants. Config option use_creterepo_c is deprecated and
prints warning to kojid.log. It should be removed completely in koji
1.21.

Fixes: https://pagure.io/koji/issue/1336

rebased onto 3e08789edc2de5ae3c4d1ebbfbc68df1daab528f

Can someone verify that a sufficiently current createrepo_c will build and run on rhel6?

@tkopecek has looked into this and I don't believe that a current createrepo_c will run on RHEL 6. I can reach out to users and see if there is a need for Koji 1.19 to support RHEL 6.

Not from scratch - it would need some changes from createrepo_c project to support RHEL6. Modularity support will not be possible even after those changes (libmodulemd is not available there).

Modularity support can be turned off, as it's a compile-time option.

So, according to @dmach it will not be possible to build createrepo for RHEL6. In such case I would propose to leave internal mergerepo in koji until support for RHEL6 will be dropped.

Opinions, @dgregor @mikem @dmach ?

It's probably the most reasonable option for now.

createrepo_c versions before modularity support was added would build fine on RHEL 6. I think even current versions would if modularity support is disabled (though I haven't tried recently).

@ngompa yes, but we want to be able to run mergerepo on RHEL6 systems with all features we need.

Pull-Request has been closed by tkopecek

@tkopecek What feature in mergerepo_c would you be missing on RHEL 6?

bare mode for now (--pkgorigins)

@tkopecek That's a single commit in createrepo_c: https://github.com/rpm-software-management/createrepo_c/commit/15484a385bd48020c76085ce1b157ce4ce37b088

It looks relatively easy to cherry-pick to whatever version you have on RHEL 6.

Metadata