Should be default=None for consistency?

Should be default=None for consistency?

yep, updated

@tkopecek How difficult would it be to make this a per dist-repo tag feature instead of a per-builder feature?

@ngompa It would be easy. What I'm struggling with, is how zdict data would appear on builder. They could be 'always there' installed via rpm (then we just need path or filename in tag's extra), or they need to be downloaded from somewhere (and url in extras), which seems to me costly.

or it is a file? and I'm nore sure if ../* could bring security issues here

@tkopecek They're significant enough that I think it's most likely they'll always be available via RPM. But it could be fetched, and maybe kojid could cache them somewhere in that case?

@julian8628 What exactly do you mean? There is a check on existence of directory few lines later.

@tkopecek I think supporting either local files (installed on builder) or fetching remotely should be supported. But I'm comfortable with this being per-tag and also being local-only if you feel that's the way to go.

I know Koji instances exist that build for multiple distributions (heck, Fedora's is one!) and it's totally conceivable to have different zdicts for each build target.

@julian8628 What exactly do you mean? There is a check on existence of directory few lines later.

Ah, I meant the GenericError is not accurate, if zck_dict_dir exists but is a file.

And I'm not sure it will modify or expose some thing under zck_dict_dir (I don't know very well about this mechanism. Sorry for that stupid question :-( )

:thumbsup:

Would this throw an error if the directory is a symlink? We probably want this to work if it is a symlink.

Commit 6ecffb8f fixes this pull-request

@ngompa It works correctly for symlinks.