#178 Expose optional rpm deps
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue142  into  master

Download 178.patch

https://pagure.io/koji/issue/142

hmm, this breaks building the rpm from the tarball (e.g. rpmbuild -tb) because of the new .spec file under tests. This is something I use regularly for quick testing.

Looks like the spec file itself is not used during the tests, just the rpm that was presumably generated from it and added separately. Renaming the spec solves the issue and does not affect the tests.

https://github.com/mikem23/koji-playground/tree/issue142

Otherwise :thumbsup:

If that change looks ok, I can merge it

Yes, it is only source for that rpm. Theoretically we don't need to add it there at all as it is contained in that test rpm. But maybe, it is something what will crystallize when we will have more rpm/spec related tests.

So, let's merge your branch for now.

Commit d06d15be fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata