koji

#1891 Disable notifications from clone-tag by default
Merged by tkopecek. Opened by cobrien.
cobrien/koji clone-no-notify  into  master

Download 1891.patch

The tagBuildBypass and untagBuildBypass invocations in the clone-tag CLI were not setting the notify option, leaving it at the default of True. This means in some cases many hundreds of notification events would be triggered from a clone-tag call.

  • Change the default behavior of clone-tag to explicitly disable notifications
  • Add a new --notify option to clone-tag to re-enable notifications for tagging and untagging of builds.

Fixes: #1890

cc @mikem @tkopecek @breilly

is the previous cmd broken on some OS?

the indents here and below are not consistent

the indents here and below are not consistent

The crazy thing there is that the indents actually are consistent, because that's the first indented argument! The previous indentations are a dict that is split over multiple lines. If you'd like I can indent the force parameter as well -- it would then line up with the first argument and the notify argument.

is the previous cmd broken on some OS?

Yes, in many cases there is no /usr/bin/nosetests (but instead a nosetests-2). This also fails situations that work with a virtualenv or alternative paths. But asking coverage to invoke the nose module that it finds on its own always works
Edited by cobrien

the indents here and below are not consistent

The crazy thing there is that the indents actually are consistent, because that's the first indented argument! The previous indentations are a dict that is split over multiple lines. If you'd like I can indent the force parameter as well -- it would then line up with the first argument and the notify argument.

ah, ok. then :thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

:thumbsup:

Commit 7b4c7aa3 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.