Based on amessina's patch
Fixes: https://pagure.io/koji/issue/84
pretty please pagure-ci rebuild
These entries do not normally exist in the dict. The entries from the latest mock config are:
config_opts['plugin_conf']['sign_enable'] config_opts['plugin_conf']['sign_opts'] config_opts['plugin_conf']['sign_opts']['cmd'] config_opts['plugin_conf']['sign_opts']['opts']
@tkopecek just curious, will this properly record things in koji's sign functionality? Like list-signed and such will work?
I'm afraid, that not. It will behave like bare rpm, so it will skip the add_rpm_sig phase. Need to test, what mock's plugin will really create and maybe update the import_rpm method.
add_rpm_sig
import_rpm
rebased onto 4f19754204b8adca37991e9173dd04da0c433de0
Ok, I've fixed one bug and tested that it will correctly parse/save signatures.
Metadata Update from @tkopecek: - Pull-request tagged with: testing-ready
Thank you @tkopecek. Will this be pulled forward to the next Koji point release?
Yes, it is scheduled for 1.22 (not 1.21.1 as it is behaviour-changing patch)
:thumbsup: for the code I think it is better to add some notes in doc to indicate that this does nothing to the sign functions of koji
note added
rebased onto c2b42abe82cdaf269a2e4af3ff70d65b03e0f714
:thumbsup:
rebased onto 171a7d9b786a511c44691f468af1c1706ab9b7fd
Metadata Update from @mfilip: - Pull-request tagged with: testing-done
rebased onto 477fb48b67b58d95ca8fb8874aa6b4c6dece19f2
Commit 62998b08 fixes this pull-request
Pull-Request has been merged by tkopecek
Based on amessina's patch
Fixes: https://pagure.io/koji/issue/84