This is not enough. I will rework this to work with replicated databases and submit a new one in a bit.

This updated sql script does not give the same result
- it changes field names
- it drops a uniqueness constraint
- it adds incorrect foreign key constraints on image_archives
- it creates the table with oids
- the insert command references a nonexistent field

How prevalent is BDR? The original method was chosen for speed. The create+insert method is slower.

Also, we used CREATE..AS SELECT in the first cgen schema update

Corrections here: https://github.com/mikem23/koji-playground/commits/cgen2-schema

Though I'm still not sure if they belong upstream

@mikem it is not the most common setup. but I expect it will become more common, we should fix up the first cgen schema also

This is not enough. I will rework this to work with replicated databases and submit a new one in a bit.

@puiterwijk are you still planning to rework this, or did my updates (linked above) cover it? Wasn't sure what you meant. Are there other sql constructs in the script that are problematic?

^ NEEDINFO @puiterwijk

Ok, closing this for now. Feel free to reopen if you have updates.

Ok, closing this for now. Feel free to reopen if you have updates.