PR#2075: Don't use datetime timestamp() as it's not in Python 2 -

koji

#2075 Don't use datetime timestamp() as it's not in Python 2

Merged Mar 16, 2020 by tkopecek. Opened Mar 10, 2020 by adamwill.

adamwill/koji no-timestamp-py2 into master

Download 2075.patch

adamwill commented Mar 10, 2020

The timestamp() method for datetime.datetime instances was
only added in Python 3. It does not exist in Python 2. So we
can't safely use it here.

I believe this should do the right thing, taking advantage of a
couple of existing utility functions in koji.util.

Signed-off-by: Adam Williamson awilliam@redhat.com

adamwill commented Mar 10, 2020

@kevin monkeypatched the Fedora instance with this patch and it seems to be working, I'm seeing apparently-sane 'Total time' and 'Task time' values for running tasks and a distinct lack of tracebacks :)

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Mar 11, 2020

tkopecek commented Mar 16, 2020

Commit d7fc15bc fixes this pull-request

Pull-Request has been merged by tkopecek

Mar 16, 2020

tkopecek commented Mar 16, 2020

Commit d7fc15bc fixes this pull-request

Pull-Request has been merged by tkopecek

Mar 16, 2020

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Mar 17, 2020

Metadata

Assignee

None

Tags

koji

#2075 Don't use datetime timestamp() as it's not in Python 2 Merged Mar 16, 2020 by tkopecek. Opened Mar 10, 2020 by adamwill. adamwill/koji no-timestamp-py2 into master

Metadata

testing-done testing-ready

#2075 Don't use datetime timestamp() as it's not in Python 2

Merged Mar 16, 2020 by tkopecek. Opened Mar 10, 2020 by adamwill.

adamwill/koji no-timestamp-py2 into master