Fixes: https://pagure.io/koji/issue/1719
Metadata Update from @tkopecek: - Pull-request tagged with: testing-ready
:thumbsup:
Looks good overall, just a couple things.
There's a typo in the updated docstring for getSRPM -- "hase". Also, as long as we're updating this docstring, I wonder if we should modernize it.
getSRPM
def getSRPM(self, src, build_tag, repo_id, rebuild_srpm=None, scratch=False):
I'm wondering if it makes sense to pass these explicitly. We could just access self.opts instead. The scratch option is less a natural parameter for this function and more a top level option for the whole task.
self.opts
scratch
rebased onto 718321298e74f6ba2ce976b38c52718c6580569e
Metadata Update from @jcupova: - Pull-request tagged with: testing-done
Commit 2bde581c fixes this pull-request
Pull-Request has been merged by tkopecek
Fixes: https://pagure.io/koji/issue/1719