#2103 fix list-signed --tag memory issues
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2102  into  master

Download 2103.patch

https://pagure.io/koji/issue/2102

:thumbsup:

Just wondering about magic numbers here (eg "5000"). Are the defaults not enough? Why 5000?

Just wondering about magic numbers here (eg "5000"). Are the defaults not enough? Why 5000?

Default is None, which means do everything in one call, it could lead to either client or server-side memory exhaustion (or due to xmlrpc overhead to big request/response denial), so it is better to do that in batches. 5000 is more a guess of size, than a justified number. For simpler cases I used a 10000 and e.g. in clone_tag it can be set by CLI option as it is very API intensive and optimal value can be found per environment / size of tag.

Ok, cool. Thanks for the explanation. I wonder if we should put a small comment here explaining the significance of 5000, so the code is easier to understand. "Tested 5000 with XX GB of memory on the hub" or something so that users know the RAM dependency.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

rebased onto eb7c33a1706c2dd1d2c9867eaf479a3c3dd76e5f

Commit 4b3c9f33 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Metadata