Extension of #1968 I've moved mock's params to config (so it is also reproducible with downloaded mock configs) and added support for images
2 new commits added
extend to allow also boostrap-image
builder: add bootstrap-chroot support for mock
@tkopecek This can be set per build tag, right?
yes
Just one note that this will slowdown builds quite a lot, because the bootstrap chroot would be created once for SRPM task and then for each arch...
It would be much better if Koji would learn how to create podman images and automatically generate one after newRepo finishes (if packages in image changed). This would make it very fast and reliable...
I see bootstrap_image as a workaround, not as proper long-term solution for prod. I think, that builders should be able to do that installation without bootstrapping. So, usecase for me is, that if I've RHEL7 builder for building F33 packages, I need to have one image "f33-base", which I can reuse every time, while buildroot is installed from current repo. I was not thinking about updating that image every time, more one-super-tested-image-per-product.
bootstrap_image
Extending it to have docker image for every repo would mean a totally different approach (I had some PoC of that) but mock was comletely obsoleted by that. I could do everything inside container in that moment. We've been discussing it a bit with @mikem and result was Abstract Buildroot Interface https://koji-planning.readthedocs.io/en/latest/Proposals/kbi.html which which should allow us to do such things.
Other option I was thinking about was to limit image to what is in koji (so, probably some docker image import by OSBS or manually). It could download it by nvr (or via buildroot contents), so it could be isolated from outside network completely.
As it stands, code-wise, this LGTM. :thumbsup:
Metadata Update from @tkopecek: - Pull-request tagged with: testing-ready
1 new commit added
use global option to enable bootstrap-image
Metadata Update from @mfilip: - Pull-request tagged with: testing-done
Metadata Update from @mfilip: - Pull-request untagged with: testing-done
fix option name
rebased onto bc2a960b72bde37407ed6483d781e705a2fc9e3c
4 new commits added
:thumbsup:
trivial thing: maybe adding some warning to indicate that mock_boostrap_image is disabled on this builder?
mock_boostrap_image
testing-ready tag was removed because of conflict in QE build. Will be tagged again after testing.
Metadata Update from @mfilip: - Pull-request untagged with: testing-ready
Metadata Update from @mfilip: - Pull-request tagged with: testing-done, testing-ready
rebased onto 54b15ce31a12ce1292637856fff9d0ca15370132
Metadata Update from @tkopecek: - Pull-request untagged with: testing-done
rebased because of conflicts and removed testing-done
Commit 6d11e0ed fixes this pull-request
Pull-Request has been merged by tkopecek
Extension of #1968 I've moved mock's params to config (so it is also reproducible with downloaded mock configs) and added support for images