From 3aca7b43a625f4223b0727677469bc426a606298 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Apr 21 2020 08:31:24 +0000 Subject: [PATCH 1/2] turn off checking external repos by default Fixes: https://pagure.io/koji/issue/2159 --- diff --git a/docs/source/utils.rst b/docs/source/utils.rst index 1e33907..0ebf78d 100644 --- a/docs/source/utils.rst +++ b/docs/source/utils.rst @@ -85,6 +85,10 @@ especially in relation to throttling in creating ``newRepo`` tasks. How many repos are being removed from disk in one iteration. This generally doesn't need to be changed. +``check_external_repos = false`` + Check also external repos, note, that you need to have your database set to + use UTC, as otherwise you can end with weird behaviour. For details see + https://pagure.io/koji/issue/2159 Garbage Collector ----------------- diff --git a/util/kojira b/util/kojira index 6425dfc..1602224 100755 --- a/util/kojira +++ b/util/kojira @@ -1030,7 +1030,7 @@ def get_options(): 'deleted_repo_lifetime': 7 * 24 * 3600, # XXX should really be called expired_repo_lifetime 'dist_repo_lifetime': 7 * 24 * 3600, - 'check_external_repos': True, + 'check_external_repos': False, 'recent_tasks_lifetime': 600, 'sleeptime': 15, 'cert': None, diff --git a/util/kojira.conf b/util/kojira.conf index 1285740..694f995 100644 --- a/util/kojira.conf +++ b/util/kojira.conf @@ -51,3 +51,8 @@ logfile=/var/log/kojira.log ; ignored repositories according to glob. Multiple masks separated by space. ; ignore_tags = + +; check also external repos, note, that you need to have your database set to +; use UTC, as otherwise you can end with weird behaviour. For details see +; https://pagure.io/koji/issue/2159 +; check_external_repos = false From 08e52da15640fca27bb9948e85ba55ff2beeb79f Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Apr 21 2020 12:25:04 +0000 Subject: [PATCH 2/2] adjust grammar --- diff --git a/docs/source/utils.rst b/docs/source/utils.rst index 0ebf78d..58e5a25 100644 --- a/docs/source/utils.rst +++ b/docs/source/utils.rst @@ -86,8 +86,10 @@ especially in relation to throttling in creating ``newRepo`` tasks. generally doesn't need to be changed. ``check_external_repos = false`` - Check also external repos, note, that you need to have your database set to - use UTC, as otherwise you can end with weird behaviour. For details see + If True, monitor external repos and trigger the appropriate Koji repo + regenerations when they change. + Note that you need to have your database set to use UTC, as otherwise + you can end with weird behaviour. For details see https://pagure.io/koji/issue/2159 Garbage Collector diff --git a/util/kojira.conf b/util/kojira.conf index 694f995..4d70695 100644 --- a/util/kojira.conf +++ b/util/kojira.conf @@ -52,7 +52,9 @@ logfile=/var/log/kojira.log ; ignored repositories according to glob. Multiple masks separated by space. ; ignore_tags = -; check also external repos, note, that you need to have your database set to -; use UTC, as otherwise you can end with weird behaviour. For details see + +; Monitor external repos and trigger the appropriate Koji repo regenerations +; when they change. Note that you need to have your database set to use UTC, +; as otherwise you can end with weird behaviour. For details see ; https://pagure.io/koji/issue/2159 ; check_external_repos = false