fixes: #2183
@mikem @tkopecek @lbalhar
:thumbsdown: there is no point in doing this since it won't work... it depends on yum and it is py2-only.
:thumbsdown:
We should delete this code and just hard-depend on mergerepo_c.
Oh, apologize for that I didn't check the python3 compatibility of this script
The simple merge mode is not supported by mergerepo_c I think.
simple
mergerepo_c
So do we really want to remove this functionality?
Is it worthy to change this script with the replacement from yum, rpmUtil to dnf, libdnf, hawkey, etc ?
All merge modes are supported by mergerepo_c. The Koji "simple" merge mode is activated via the --koji switch.
--koji
PR #2185 to delete mergerepos
mergerepos
No, it is not the same AFAIK simple: mergererepos --simple - we can't do that with mergerepos_c yet. koji: mergerepos_c --koji bare: mergerepos_c --pkgorigins --all (or mergerepos --koji)
mergererepos --simple
mergerepos_c
mergerepos_c --koji
mergerepos_c --pkgorigins --all
mergerepos --koji
The question is, if bare mode is not usable in place of simple. The difference is that bare ignores blocklist. @mikem is there any other significant difference now?
bare
there's mergerepo_c --koji --simple since createrepo_c-0.15.1
mergerepo_c --koji --simple
https://github.com/rpm-software-management/createrepo_c/blob/master/doc/mergerepo_c.8#L113
Not quite sure if it is usable right now
It could be, we need to check version of mergerepos_c if it contains support for that.
https://github.com/rpm-software-management/createrepo_c/issues/213 was merged so we can continue with this one.
replaced with #2343
Metadata Update from @tkopecek: - Pull-request tagged with: testing-ready
Metadata Update from @tkopecek: - Pull-request untagged with: testing-ready
Pull-Request has been closed by julian8628
fixes: #2183