#220 Limit the GSSAPI retries
Merged by mikem. Opened by puiterwijk.
puiterwijk/koji limit-gssapi-retries  into  master

Download 220.patch
no initial comment

Is this something that's read from koji.conf? If it is, then it should have appropriate documented lines in the koji.conf file included, so that people know what options can be changed and what they do.

I'm also not particularly enthused by this nondescript option name. Can you come up with something a little bit more descriptive of what this does?

ngompa -- this is not the sessions opts, but the kwargs for the hub call

abusing the method kwargs for this is a no-go. This would interfere with any rpc call having a kwarg of the same name. Just have gssapi_login call _callMethod directly

I've got an update for the comments here:
https://github.com/mikem23/koji-playground/commits/gssapi-fixes

I'll pull all this in once I get a successful test with stg

Commit 2918ba29 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata