koji

#2254 openRemoteFile retries and checks downloaded content
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2130  into  master

Download 2254.patch

Fixes: https://pagure.io/koji/issue/2130

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 new commits added

  • lib: check consistency of rpm from openRemoteFile
  • lib: retry openRemoteFile and check size

rebased onto eb3788a63741c072db8d8e69465ff96dc0d9c55f

please see also ticket #2282 , tasks.py/localPath() suffers from the same issues as openRemoteFile()

1 new commit added

  • use downloadFile for localPath and openRemoteFile

rebased onto a408e9dc046c57bc18175257ba5ac3166ec5df4d

Right, I've forced them to use same downloadFile

OK, I am "stuck" at 1.20.1 level, because it's what's on the Fedora builders :-)

Metadata Update from @julian8628:
- Pull-request untagged with: testing-ready

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

rebased onto ac1d21ab1018966d765bc18639460ead6b96bf2a

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

:thumbsup:

pretty please pagure-ci rebuild

1 new commit added

  • fix flake8 issues

Commit 7eacf6bc fixes this pull-request

Pull-Request has been merged by tkopecek

first catch on buildvm-s390x-08

2020-06-05 18:38:43,933 [INFO] koji.TaskManager: Attempting to take task 45461806
2020-06-05 18:38:47,814 [INFO] koji.TaskManager: pids: {45461806: 2563043}
2020-06-05 18:38:47,919 [INFO] koji.TaskManager: open task: {'waiting': None, 'id': 45461806, 'weight': 1.5}
2020-06-05 18:38:57,683 [WARNING] koji.TaskManager: TRACEBACK: Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/koji/daemon.py", line 1294, in runTask
    response = (handler.run(),)
  File "/usr/lib/python3.7/site-packages/koji/tasks.py", line 312, in run
    return koji.util.call_with_argcheck(self.handler, self.params, self.opts)
  File "/usr/lib/python3.7/site-packages/koji/util.py", line 263, in call_with_argcheck
    return func(*args, **kwargs)
  File "/usr/sbin/kojid", line 1338, in handler
    fn = self.localPath("work/%s" % pkg)
  File "/usr/lib/python3.7/site-packages/koji/tasks.py", line 482, in localPath
    koji.downloadFile(url, path=fn)
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 1706, in downloadFile
    (url, fo.tell(), resp.headers['Content-Length']))
koji.GenericError: Downloaded file http://kojipkgs-cache01.s390.fedoraproject.org/work/tasks/1775/45461775/espresso-4.1.2-4.fc33.src.rpm doesn't match expected size (22837386 vs 22934903)
2020-06-05 18:39:07,146 [INFO] koji.TaskManager: pids: {45461806: 2563043}
2020-06-05 18:39:07,255 [INFO] koji.TaskManager: Task 45461806 (pid 2563043) exited with status 0
2020-06-05 18:39:07,263 [INFO] koji.TaskManager: Expiring subsession 102577734 (task 45461806)

The good news is that the user gets a accurate information about why the build failed.
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.