#2274 Replace requests_kerberos with requests_gssapi when available
Closed by simo. Opened by simo.
https://pagure.io/forks/simo/koji.git master

Download 2274.patch

We want to retire python-kerberos which is used by requests_kerberos, so move koji off of using that old package to the replacement requests_gssapi which uses python-gssapi

pretty please pagure-ci rebuild

rebased onto 81cf9385f8b2ec6a0301929ca1d3ece6ac53187c

I'm a bit confused here, don't we already support gssapi?

ngompa, we "support" it currently by using a crummy old python-kerberos package that we want to remove since ages.
requests-kerberos -> python-kerberos
requests-gssapi -> python-gssapi

The latter one is what we want to support in the krb5/gssapi world.

pretty please pagure-ci rebuild

Ah, okay!

This should be fixed.

This PR makes python-requests-kerberos invalid as a dependency everywhere. Replace it instead of adding more conditionals.

I do not understand the CI failures, can someone exaplain to me?
I do not spot an actual failure anywhere

@ngompa unfortunately rquests-gssapi is not available on EL<=7 and not yet available in EL8 so I am using a soft approach...

Cool, we already have an issue for this: #882

tests says, that they are even not able to merge it to master without problems. You can try tests locally via make test3 && make flake8

I do not understand how it cannot merge to master given this PR is a single commit on top of master.

As for testing I am encountering some errors like the fact that requests_mock is not something available on my Fedora OS.

I also see an import issus in one of the tests I do not know how to handle.
I import request_gssapi or requests_kerberos as "reqgssapi", and the mock tests seem to try to import a module named "reqgssapi" directly ?
Guidance would be helpful.

And this is all I get with make flake8:

$ make flake8
error: line 93: Unknown tag:  <= 32BuildArch: noarch
error: query of specfile koji.spec failed, can't parse
error: line 93: Unknown tag:  <= 32BuildArch: noarch
error: query of specfile koji.spec failed, can't parse
flake8

rebased onto 457a71a45523f48abb443a46edb88a04369a8865

These lines are part of the problem. What it should have done? Something is missing there.

Oh ouch, I had a stray paste in there, sorry, fixed that, flake8 reports no errors now

rebased onto 3a51318cceb2c94d2333851e70c43d278dfc7773

Here it should be 'koji.reqgssapi.HTTPKerberosAuth'.

'Here' means ?

I see this issue in Jenkins:

+ git remote rm proposed
fatal: No such remote: 'proposed'

I think this is due to the fact pagure was too slow to try to load my tree so I added the git tree manually to create the PR (as if it were a completely remote source).
Somehow I do not think Jenkins properly understand how to deal with that.

Should I try to create a new PR ?

https://pagure.io/koji/pull-request/2274#c-024067e50c7044b85564ebcb15974bf8d1914dbb-15 (you can click on "commented on line" title).

After fixing you can try to open new PR. Not sure, what is wrong here, but head looks differently compared to other PRs (here is full repo url, while e.g. in PR #2275 it only says tkopecek/koji in that place).

Ok I figured out the title thing and fixed the issue.

As for opening a new PR the problem is that whenever I open the "Open PR" menu, the spinners spin foever and never give me the ability to select my tree to open a PR, that's why I opened it manually last time.

np, I can test it + merge locally. Don't bother with that.

Opened #2280 to replace this PR

Pull-Request has been closed by simo

Metadata