koji

#2301 avoid redundant clauses and joins in query_buildroots()
Merged by tkopecek. Opened by mikem.
mikem/koji redundant-joins  into  master

Download 2301.patch

Fixes https://pagure.io/koji/issue/2300

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Do we want to drop this field? It is (probably) not used anywhere, but it still an API change.

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Do we want to drop this field? It is (probably) not used anywhere, but it still an API change.

I talked about that a little in #2300. It is technically an api change. We don't rely on the field anywhere, and the polymorphism of the result is a little odd (the field is only present when querying by rpmID).

Also, I think most (all?) places in the code where we query buildroots by rpm_id we use listRPMs instead.

It seemed strange to have the changes from #2274 yet still have those joins. Seems to almost defeat the point. Am I thinking about it wrong?

Yes, I agree it should be there. I was a bit afraid just about dropping this field. :thumbsup:

Commit 6e501202 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.