koji

#2359 hub: importImage doesn't honor volume
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue2355  into  master

Download 2359.patch

We're not sending updated build_info to the method and it is requesting
data from db. There is not volume saved yet.

Change is reusing modified buildinfo.

Fixes: https://pagure.io/koji/issue/2355

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

1 new commit added

  • fix tests

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

It's always a red flag for me when I see an established function change signature. This signature change is more than cosmetic as the underlying behavior around the rename argument changes too (necessarily).

However, I think this is OK, but let me explain my thinking while I'm here.

  • importImageInternal is a purely internal function on the hub
  • it is only called from one place (Host.importImage), which is in turn only called from one place (Host.completeImageBuild).

Given that the only place we're called from is passing in a deliberately modified build_info, it makes sense to rely on that instead of querying.

Commit 7d998fec fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.