Note that this is inconsistent with the option name for builders (where it's krb_principal), but this is due to the fact that the argument in the koji CLI is called "principal".
If we want to make it consistent without breaking either backwards compatibility with the builders' config files or the clients' command line, we would need to make a special case in the CLI options override.

adds an unused ccache option?

This patch gets these values into the ClientSession opts, but nothing in ClientSession uses these opts. The krb_login() method does not look at opts for credential values.

(nm the silly comment I just deleted)

This patch gets these values into the ClientSession opts, but nothing in ClientSession uses these opts. The krb_login() method does not look at opts for credential values.

The cli's activate_session function uses options.principal and options.keytab in its call to krb_login.
The goal here is to allow cli/koji to use these options.

The cli's activate_session function uses options.principal and options.keytab in its call to krb_login.
The goal here is to allow cli/koji to use these options.

yep yep. Sorry I completely misread part of it at first

You have the cli parsing them as integers, though :)

                  You have the cli parsing them as integers, though :)

Hah, that was not intended, I don't think numerical keytabs or principals would work very well :smile:

Commit 86ff1b0a fixes this pull-request