koji

#2450 serverca property from KojiHubCA web config
Closed by tkopecek. Opened by lrossett.
lrossett/koji kojiweb-ca-fix  into  master

Download 2450.patch

fixes #2448

Changes

  • sets serverca for session if KojiHubCA is available in environ using an empty string as default value
  • package dependencies update in setup.py

Is this related to https://pagure.io/koji/issue/2448 ?

oh it is, I can improve the error message as well if you want to.

pretty please pagure-ci rebuild

2 new commits added

  • requests exception
  • set serverca opts

rebased onto 3fc39e76dd33babe6fc614463bc0814bb241ad3a

pretty please pagure-ci rebuild

rebased onto 657f9d9bdc1aac68f6ceb8478dd632286fc80f69

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

lol why did the test pass now :-)

it looked like some weird dependency error for librepo just for El7 and F29

OK I see the job changed.. could I get a review again for this PR?
Edited by lrossett

librepo is not installed on all workers in jenkins :-(

I think each job runs in a VM.. so the image being used may need an update.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

rebased onto 0a5d1bbda34c252dd80edf0f85d68909de3a9196

LGTM (untested)

:thumbsup:

merged (script failed to do proper merge request, but commits are in master)

https://pagure.io/koji/c/1c787a323ff1644fdd88bd298532437e4f505e98?branch=master
https://pagure.io/koji/c/ff8c13969e64691b213c0cd2a263c18b607f6e54?branch=master
https://pagure.io/koji/c/74061d5d710155c0888c155df0ac3c0c40a96d41?branch=master

Pull-Request has been closed by tkopecek

This PR includes changes unrelated to the description.

The whitespace change in kojikamid is probably ok, though I prefer to keep pull requests on topic.

However, the change to ClientSession looks like some debug code that accidentally slipped in. This change defeats Koji's retry mechanism in some situations and we'll need to revert that.
Edited by mikem

Filed #2786

Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.