koji

#2457 hub: more verbose assertPerm error
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2429  into  master

Download 2457.patch

Fixes: https://pagure.io/koji/issue/2429

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

@mikem maybe use VerbosePolicy settings also for this?

@mikem maybe use VerbosePolicy settings also for this?

This isn't policy code, so I don't think that setting should apply

 
            msg = "%s permission required" % name
            if self.logged_in:
                msg += ' (logged as %s)' % self.user_data['name']
            else:
                msg += ' (user not logged in)'
            raise koji.ActionNotAllowed(msg)

"logged as" => "logged in as"

otherwise, looks good to me!

rebased onto b4cfca052b014ab56c856ef67bf141fcca8e3b86

Commit 9c92f5e4 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.