#2493 getBuildConfig returns inheritance history
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue1870  into  master

Download 2493.patch

%SUBJ% + taginfo shows inherited extra

@mikem @julian8628 I've extended getBuildConfig to return also basic inheritance data (without full chain. It is for free (only sending a bit more data over the wire).

If you see it usable as next step I would extend getBuild(taginfo, event, strict) to getBuild(taginfo, event, strict, inherit) and make getBuildConfig alias to this? (separate issue)

If merged - I would use it in #2472 to get inherited extra.

related to #2495

Fails if used against old hub:

Traceback (most recent call last):
  File "/home/mikem/Devel/koji/koji/cli2/lkoji", line 337, in <module>
    rv = locals()[command].__call__(options, session, args)
  File "/home/mikem/Devel/koji/koji/cli/koji_cli/commands.py", line 4888, in anon_handle_taginfo
    if key in info['extra_inheritance']:
KeyError: 'extra_inheritance'

Minor:

[mikem@localhost koji]$ git diff origin... |flake8 --diff
tests/test_hub/test_get_build_config.py:6:1: E302 expected 2 blank lines, found 1

Other than that, the change looks fine

2 new commits added

  • flake8 fix
  • fix backward compatibility

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

:thumbsup:

It seems we could show the inheritance for arches as well.
Does it make sense to do this in the output of taginfo?

1 new commit added

  • extend to config_inheritance

I've changed it to more broad config_inheritance, but not exposing it anywhere yet.

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

rebased onto 172c8614426bcf7c15656b4310fd7a30339d243e

Commit bfd30341 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata