koji

#2495 blocking inherited extra
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2283  into  master

Download 2495.patch

WIP: I've converted column to jsonb which allow us to differentiate between SQL NULL and jsonb null. Anyway, current state lacks an ability for user to find which tag is responsible for blocking (blocked values simple got lost). I'll wait for #2493 resolution as it is interlinked a bit.

which allow us to differentiate between SQL NULL and jsonb null.

There are several reasons that jsonb would be useful (mostly speed and more powerful querying), but I don't think this is one of them. We could allow a null value (or perhaps just an empty string value) in the existing text field.

rebased onto 9e1edb884415b70fb3c89c4905e74d468e845341

Yep, I was overengineering, that we would like to differentiate between SQL NULL and None value in the field. So, mock.new_chroot: None would be different to mock.new_chroot: NULL where first one says extra option exists and is set to None while the second says it is blocked. But it probably has not much real use and we can interpret missing value as None always.

rebased onto 9d561ae19e1262e5d2480c8d424ff4a14e02a04b

rebased onto 8d3fdc7ab72971de7f82aa7179ffe6ac17daa282

rebased onto f5222ac626cf2a7f6f7659ef8e7777afd8626527

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Commit 5e8ed0c1 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.