:thumbsup:

build is undefined if data['build'] is not a string. Otherwise, :thumbsup:

updated

it could be an int as build_id

:thumbsup:

Note that in light of #2511, this change is of questionable value at the moment.

Unless we can address #2511, likely we'll have to take an approach more like policy_get_brs where we examine the build components. This would be most in line with the policy at CG Import time.

Moved to 1.24 (with #2511) as it needs more work.

Unless we can address #2511, likely we'll have to take an approach more like policy_get_brs where we examine the build components. This would be most in line with the policy at CG Import time.

I think when I looked at this before, I must not have looked at enough diff context. The existing policy test does look at buildroot data and has for years.

Looking at build.cg_name is faster, but less reliable. When we added the field, we did not provide a mechanism to populate it for existing data, so there are old content generator builds where the only way to determine this is to look at the buildroots.

The current change overrides the buildroot check for such builds, even when cg_id is not set for the build. So looks like this will return {} in cases where the old code would return a more correct answer.

:thumbsdown:

It looks that we've solved most problems with other PRs. Let's close this one for now.