#2548 kojira: don't expire ignored tags with targets
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2542  into  master

Download 2548.patch

Fixes: https://pagure.io/koji/issue/2542

I think it is just ok to not expire these. @mikem any concerns?

I think it is just ok to not expire these. @mikem any concerns?

Hmm. So, this is all with MBS in mind, and MBS cleans up its own targets. Once it does that Kojira will delete the repos.

However, MBS never cleans up repos. So if these repos are regenerated multiple times (which MBS definitely does), I don't think we have a process that will get rid of those, at least until the target itself is removed.

Maybe this is ok, but with the current long target lifetime we have configured, I'm not sure.

The ignored_build_tags set is only used within the checkNeeded function. Does it need to be an instance variable? Granted, the same is true for self.build_tags.

I don't think we have a process that will get rid of those

Oh, nm, I guess that's handled in repoDone when a new repo replaces the old.

1 new commit added

  • remove instance variables

updated

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

:thumbsup:

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 88ad6854 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata