#2564 external repos can have specified arch list
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2538  into  master

Download 2564.patch

Fixes: https://pagure.io/koji/issue/2538

This needs clearer handling of the separators. In particular, the builder code expects space (repo['arches'].split()), but the cli suggests commas (metavar="ARCH1,ARCH2, ...").

Elsewhere in Koji, we tend to use spaces to separate arches in a list since this makes splitting easier. However, passing a space separated list to an --arch option is awkward because of the quoting needed. I suggest accepting either one in the cli and passing a space separated list to the hub call. I thought we had code to do this for archlists somewhere else, but I can't seem to find it right now.

ah, yes, we've that koji.parse_arches - added

rebased onto 4e6b8d55f412ae8af7a6f1d8782be0b626648304

1 new commit added

  • hub: use CTE for build_references

2 new commits added

  • parse arches
  • external repos can have specified arch list

Metadata Update from @mfilip:
- Pull-request tagged with: testing-ready

rebased onto a2523ee7c9da97944b83315ad04f4171edf964dc

rebased onto c79114b4b381bb1c594823175504f03bd32bc128

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

ah, yes, we've that koji.parse_arches - added

I don't see this in the current change set. Was it lost somewhere in the rebase?

Without it, my concerns above still apply.

I think the best place to handle this is in the hub call. I'd like to be sure that the arch list is sanitized to space separated before it goes into the db.

1 new commit added

  • parse arches

Hmm, bad rebase. Updated.

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-done

rebased onto 99f440f4bbf7cb572443f52d2623c1235c072ed6

2 new commits added

  • parse arches
  • external repos can have specified arch list

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 5e3e7c4b fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata