koji

#2589 history query by key
Merged by tkopecek. Opened by mikem.
mikem/koji extra-history  into  master

Download 2589.patch

At times I've wanted to query history only for a specific tag extra key (e.g. rpm.macro.dist). This enables that.

I'm a little confused by the help text about "related to given key". Can we say "related to a given tag extra key"?

(Ie, no other "keys" on other tables, and not GPG "keys")

I've created #2590

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

I'm a little confused by the help text about "related to given key". Can we say "related to a given tag extra key"?

good point. Perhaps it is even worth using --xkey instead?

1 new commit added

  • rename arg

rebased onto c3a4f088b77ac9cd6d351daf99ca7de23f8f7796

Any strong opinions on --key vs --xkey?

no

ok, let's go with xkey to reduce chance of confusion

Metadata Update from @mikem:
- Pull-request untagged with: testing-done

Sounds good to me. I think as long as --help makes it clear, it will help new users

Please modify also command help string and not only option help string, thanks.

@mfilip What do you mean here? There is no mention of this option in command help string? (https://pagure.io/koji/blob/master/f/cli/koji_cli/commands.py#_4458)

@tkopecek Sorry I overlooked it, it's ok

:thumbsup:

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 26ea01a7 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.