koji

#263 Error message for missing certificates
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue250  into  master

Download 263.patch
no initial comment

Ah, the cert defaults in kojid are wrong. We need to do the same thing there that we do in koji.read_config().

1 new commit added

  • backward-compatible default value for kojid certs

This is not exactly same behaviour as before. Now there is no way to set serverca/cert to None. It will be always replaced by default value and fallback to PKI will not happen. Is it something we want?
Edited by tkopecek

Question in code.

This is in the ssl_login method. This login method has always required a valid and explicit serverca setting.

Granted, we might be able to lower that restriction now and let the system fall back to pki

1 new commit added

  • Don't require cert/serverca for kojid

This looks fine, but the original issue also asked about kojira and koji-gc. Would you like to update those here or make a separate PR?

I've merged it here.

rebased

This allows cert=None to proceed, which cannot work

rebased

Reverted 'cert is None'.

Commit 1593e03e fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.