koji

#2660 attempting to bridge the gap with pip
Closed by tkopecek. Opened by cobrien.
cobrien/koji pkg_resources  into  master

Download 2660.patch

Attempt at a fix for https://pagure.io/koji/issue/912

Uses the appropriate rpm macros for installing python wheels to provide the base koji lib. Packages the resulting dist-info data as well.

Because the RPM packaging of koji is slightly different (the koji_cli_plugins and some of the special utils are listed in setup.py but are actually broken up to be distinct subpackages in the RPM) we modify the spec slightly to omit those aspects and allow them to continue to be installed via make.

Note I still need to do more testing on this -- I'm setting up containers to verify that the python2 and python3 variations not only install but function correctly when bundled this way. But I'd appreciate some initial review and feedback :)
Edited by cobrien

Looks like we'll need to add some buildrequires to make sure the wheel tools are around.

https://fedoraproject.org/wiki/PythonWheels

You may need to turn off the py2 support for Fedora 32 then, because it seems they dropped python2-pip and python2-wheel at that point. Current logic in the spec presumes Fedora 33 for the py2 drop.
Edited by cobrien

Dropping a subpackage from a stream is a big deal. Can we disable the wheel build in this instance instead?

I guess either that or wait for F32 to die ;)

I just went looking, and I don't actually see python2-koji in fedora32, but I could probably hack in a check to fall back to make for python2 installs under fedora32. I don't actually see a fedora32 python2-koji package, so I wonder how far back they switched to python3 only?

so I wonder how far back they switched to python3 only?

Looks like they switched in F31
F30 has it -- https://koji.fedoraproject.org/koji/buildinfo?buildID=1500116
F31 does not -- https://koji.fedoraproject.org/koji/buildinfo?buildID=1607544

I think that dropping it for F32 is ok. Problem I see is in centos 7. (centos 8 works for me)

@mikem @cobrien Jana added few changes in #2821. Main change is that building on RHEL/CentOS 7 now requires EPEL enabled (for py2 wheel/pip). Anyway, I think it is ok as installation needs it already (requests-gssapi). Can you look at it?

2821 merged

Pull-Request has been closed by tkopecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.