Fixes: https://pagure.io/koji/issue/2541
Metadata Update from @tkopecek: - Pull-request tagged with: testing-ready
:thumbsup:
rebased onto b4e456855e47ea75f38f948313ad083e9aed6496
#if $rpm.external_repo_id and $vcs <tr> <th><label title="Package source code VCS location">VCS</label></th><td>$vcs</td> </tr> #end if #if $rpm.external_repo_id and $disturl <tr> <th><label title="">DistURL</label></th><td>$disturl</td> </tr>
The checks on $rpm.external_repo_id need to be flipped. We can only get this data for koji's rpms.
$rpm.external_repo_id
This is right after a #if $rpm.external_repo_id == 0 block. Perhaps just enclose this in that block by moving the #end if?
#if $rpm.external_repo_id == 0
#end if
Otherwise looks fine
rebased onto 39fa07a109313fc33f4f9ffda8e23f9febbc938b
Metadata Update from @jobrauer: - Pull-request tagged with: testing-done
VCS tag verified, but I wasn't able to make a build with disturl tag - build fails with 'bogus tag 1123'. Presumably (from what I found) it's not supported yet (?) - please, correct me if I'm wrong.
It is not supported in fedora's rpm directly. You can nevertheless create it even with such rpm via'%disturl https://random.dist.url' macro definition (e.g. via ~/.rpmmacros)
Commit ec3ef399 fixes this pull-request
Pull-Request has been merged by tkopecek
Ok, thanks for the info. I'll check it that way afterwards.
Fixes: https://pagure.io/koji/issue/2541